lib: support glob on `--watch-path` by louiellan · Pull Request #59478 · nodejs/node

louiellan · 2025-08-15T04:43:46Z

This allows glob patterns to be included in the --watch-path option but it does introduce breaking change since there might be instances where developers might have used glob characters when using --watch-path (e.g., file[1].js)

An alternative, non-breaking change would be to add a cli option --watch-pattern in which the PR is here #59345

MoLow

Im in favor of this variaton

nodejs-github-bot · 2025-08-16T19:29:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68673/

nodejs-github-bot · 2025-08-17T03:54:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68675/

avivkeller · 2026-01-03T20:21:35Z

@louiellan Thanks for the PR! Can you please rebase?

codecov · 2026-01-04T14:24:40Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (282d30e) to head (20a16e8).
⚠️ Report is 122 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #59478      +/-   ##
==========================================
- Coverage   88.53%   88.53%   -0.01%     
==========================================
  Files         704      704              
  Lines      208759   208760       +1     
  Branches    40277    40272       -5     
==========================================
- Hits       184825   184819       -6     
- Misses      15934    15943       +9     
+ Partials     8000     7998       -2

Files with missing lines	Coverage Δ
lib/internal/fs/glob.js	`91.39% <100.00%> (+0.01%)`	⬆️

... and 40 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-01-10T09:39:43Z

Failed to start CI

   ⚠  Commits were pushed since the last approving review:
   ⚠  - lib: support glob on `--watch-path`
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/20876405993

louiellan · 2026-01-21T11:22:58Z

I think this might be the reason why the CI is failing, I changed this when I rebased, my bad

node/test/sequential/test-watch-mode.mjs

Lines 136 to 137 in 20a16e8

    
           if (isWatchingSingleFile && completes === 1) 
        
             cancelRestarts = restart(watchedFile);

nodejs-github-bot · 2026-01-21T15:02:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70941/

nodejs-github-bot · 2026-01-21T21:24:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70949/

nodejs-github-bot · 2026-01-21T22:11:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70952/

nodejs-github-bot · 2026-01-22T09:17:00Z

Commit Queue failed

- Loading data for nodejs/node/pull/59478
✔  Done loading data for nodejs/node/pull/59478
----------------------------------- PR info ------------------------------------
Title      lib: support glob on `--watch-path` (#59478)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     louiellan:watch-path-glob -> nodejs:main
Labels     fs, semver-major, author ready, needs-ci
Commits    1
 - lib: support glob on `--watch-path`
Committers 1
 - louiellan <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/59478
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/59478
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 15 Aug 2025 04:43:46 GMT
   ✔  Approvals: 2
   ✔  - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/59478#pullrequestreview-3687694822
   ✔  - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/59478#pullrequestreview-3602246900
   ✘  semver-major requires at least 2 TSC approvals
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-01-21T22:11:50Z: https://ci.nodejs.org/job/node-test-pull-request/70952/
- Querying data for job/node-test-pull-request/70952/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/21242759144

louiellan · 2026-01-22T09:52:02Z

Just added my email ;>

nodejs-github-bot · 2026-01-22T12:19:40Z

Commit Queue failed

- Loading data for nodejs/node/pull/59478
✔  Done loading data for nodejs/node/pull/59478
----------------------------------- PR info ------------------------------------
Title      lib: support glob on `--watch-path` (#59478)
Author     Louie Llaneta <[email protected]> (@louiellan, first-time contributor)
Branch     louiellan:watch-path-glob -> nodejs:main
Labels     fs, semver-major, author ready, needs-ci
Commits    1
 - lib: support glob on `--watch-path`
Committers 1
 - louiellan <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/59478
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/59478
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 15 Aug 2025 04:43:46 GMT
   ✔  Approvals: 2
   ✔  - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/59478#pullrequestreview-3687694822
   ✔  - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/59478#pullrequestreview-3602246900
   ✘  semver-major requires at least 2 TSC approvals
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-01-22T09:17:00Z: https://ci.nodejs.org/job/node-test-pull-request/70952/
- Querying data for job/node-test-pull-request/70952/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/21248171608

MoLow · 2026-01-22T13:51:56Z

@nodejs/tsc please take a look and approve as this is semver major

RafaelGSS

We should include a permission model test for glob when using --permission and --watch-path

louiellan · 2026-01-24T00:18:47Z

So I was creating the permission model tests, and came across this bug (I guess), might have to resolve this first
#61499

nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Aug 15, 2025

louiellan mentioned this pull request Aug 15, 2025

lib: adding --watch-pattern to support watching files/dirs with glob #59345

Open

MoLow added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 16, 2025

MoLow approved these changes Aug 16, 2025

View reviewed changes

MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 16, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 16, 2025

lib: support glob on --watch-path

20a16e8

louiellan force-pushed the watch-path-glob branch from 46be19d to 20a16e8 Compare January 4, 2026 12:46

avivkeller added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 4, 2026

github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jan 4, 2026

This comment has been minimized.

Sign in to view

avivkeller approved these changes Jan 4, 2026

View reviewed changes

avivkeller added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Jan 4, 2026

github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jan 4, 2026

This comment has been minimized.

Sign in to view

avivkeller added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 9, 2026

github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jan 10, 2026

louiellan requested a review from MoLow January 21, 2026 11:23

MoLow approved these changes Jan 21, 2026

View reviewed changes

MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2026

MoLow removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Jan 21, 2026

MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 22, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 22, 2026

MoLow added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 22, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 22, 2026

RafaelGSS reviewed Jan 22, 2026

View reviewed changes

louiellan mentioned this pull request Jan 24, 2026

fs.globSync can't traverse on allowed directory by specific --allow-fs-read #61499

Open

louiellan marked this pull request as draft January 28, 2026 12:27

louiellan added 3 commits January 28, 2026 20:58

test: add tests for using with --permission

f66eeda

doc: clarify glob support for --watch-path

a07b594

test: fix lint issues

27d6f80

Uh oh!

Conversation

louiellan commented Aug 15, 2025 • edited by MoLow Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MoLow left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Aug 16, 2025

Uh oh!

nodejs-github-bot commented Aug 17, 2025

Uh oh!

avivkeller commented Jan 3, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

codecov bot commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jan 10, 2026

Uh oh!

louiellan commented Jan 21, 2026

Uh oh!

nodejs-github-bot commented Jan 21, 2026

Uh oh!

nodejs-github-bot commented Jan 21, 2026

Uh oh!

nodejs-github-bot commented Jan 21, 2026

Uh oh!

nodejs-github-bot commented Jan 22, 2026

Uh oh!

louiellan commented Jan 22, 2026

Uh oh!

nodejs-github-bot commented Jan 22, 2026

Uh oh!

MoLow commented Jan 22, 2026

Uh oh!

RafaelGSS left a comment

Choose a reason for hiding this comment

Uh oh!

louiellan commented Jan 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

louiellan commented Aug 15, 2025 •

edited by MoLow

Loading

codecov bot commented Jan 4, 2026 •

edited

Loading